Fix NoMethodError: undefined method 'name' for nil:NilClass in Rails

This error occurs when you call a method on a variable that is nil, typically because a database query returned no record. In Rails, calling .find_by or .first on a model can return nil. Fix it by using the safe navigation operator (&.) or adding a nil check before accessing methods on the result.

Reading the Stack Trace

Here's what each line means:

• app/controllers/users_controller.rb:12:in `show': The show action at line 12 calls .name on a variable that is nil because the user was not found in the database.
• lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action': Rails dispatched the show action, which crashed before rendering a response.
• lib/abstract_controller/callbacks.rb:234:in `block in process_action': The error occurred during action processing, after any before_action callbacks ran successfully.

Common Causes

class UsersController < ApplicationController
  def show
    user = User.find_by(id: params[:id])
    @name = user.name
  end
end

class OrdersController < ApplicationController
  def show
    @order = Order.find(params[:id])
    @customer_name = @order.customer.name  # customer could be nil
  end
end

The Fix

Use User.find instead of find_by, which raises ActiveRecord::RecordNotFound when the record does not exist. Rescue the exception to return a proper 404 response instead of a 500 error.

class UsersController < ApplicationController
  def show
    user = User.find_by(id: params[:id])
    @name = user.name
  end
end

class UsersController < ApplicationController
  def show
    @user = User.find(params[:id])
    @name = @user.name
  rescue ActiveRecord::RecordNotFound
    render plain: 'User not found', status: :not_found
  end
end

Testing the Fix

require 'rails_helper'

RSpec.describe UsersController, type: :controller do
  describe 'GET #show' do
    context 'when the user exists' do
      let(:user) { User.create!(name: 'Alice', email: 'alice@example.com') }

      it 'returns 200' do
        get :show, params: { id: user.id }
        expect(response).to have_http_status(:ok)
      end

      it 'assigns the user name' do
        get :show, params: { id: user.id }
        expect(assigns(:name)).to eq('Alice')
      end
    end

    context 'when the user does not exist' do
      it 'returns 404' do
        get :show, params: { id: 99999 }
        expect(response).to have_http_status(:not_found)
      end
    end
  end
end

Run your tests:

rspec

Pushing Through CI/CD

git checkout -b fix/nomethoderror-nil-user,git add app/controllers/users_controller.rb spec/controllers/users_controller_spec.rb,git commit -m "fix: handle missing user with find and rescue RecordNotFound",git push origin fix/nomethoderror-nil-user

Your CI config should look something like this:

name: CI
on:
  pull_request:
    branches: [main]
jobs:
  test:
    runs-on: ubuntu-latest
    services:
      postgres:
        image: postgres:15
        env:
          POSTGRES_DB: test_db
          POSTGRES_USER: postgres
          POSTGRES_PASSWORD: postgres
        ports:
          - 5432:5432
        options: >-
          --health-cmd pg_isready
          --health-interval 10s
          --health-timeout 5s
          --health-retries 5
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-ruby@v1
        with:
          ruby-version: '3.2'
          bundler-cache: true
      - run: bundle exec rails db:create db:migrate
        env:
          DATABASE_URL: postgres://postgres:postgres@localhost:5432/test_db
          RAILS_ENV: test
      - run: bundle exec rspec
        env:
          DATABASE_URL: postgres://postgres:postgres@localhost:5432/test_db
          RAILS_ENV: test

The Full Manual Process: 18 Steps

Here's every step you just went through to fix this one bug:

1. Notice the error alert or see it in your monitoring tool
2. Open the error dashboard and read the stack trace
3. Identify the file and line number from the stack trace
4. Open your IDE and navigate to the file
5. Read the surrounding code to understand context
6. Reproduce the error locally
7. Identify the root cause
8. Write the fix
9. Run the test suite locally
10. Fix any failing tests
11. Write new tests covering the edge case
12. Run the full test suite again
13. Create a new git branch
14. Commit and push your changes
15. Open a pull request
16. Wait for code review
17. Merge and deploy to production
18. Monitor production to confirm the error is resolved

Total time: 30-60 minutes. For one bug.

gem install bugstack

require 'bugstack'

Bugstack.init(api_key: ENV['BUGSTACK_API_KEY'])

Deploying the Fix (Manual Path)

1. Run rspec locally to confirm the controller handles missing users.
2. Open a pull request with the RecordNotFound rescue.
3. Wait for CI checks to pass on the PR.
4. Have a teammate review and approve the PR.
5. Merge to main and verify the 404 page renders in staging.

Frequently Asked Questions