Fix ActiveRecord::RecordInvalid: Validation failed: User must exist in Rails

This error occurs because Rails 5+ requires belongs_to associations to be present by default. When you create a record without setting the foreign key, the validation fails. Either provide the associated record, set optional: true on the belongs_to declaration, or ensure the foreign key is correctly assigned before saving.

Reading the Stack Trace

Here's what each line means:

• activerecord (7.1.3) lib/active_record/validations.rb:84:in `raise_validation_error': ActiveRecord raises this error because the belongs_to validation failed on save!.
• activerecord (7.1.3) lib/active_record/associations/builder/belongs_to.rb:115:in `validate_each': The automatic belongs_to presence validation checks that the associated user exists.
• app/controllers/comments_controller.rb:12:in `create': The controller create action does not assign a user to the comment.

Common Causes

def create
  @comment = Comment.new(comment_params)
  @comment.save!  # user_id is nil
end

class Comment < ApplicationRecord
  belongs_to :user  # Required by default in Rails 5+
  belongs_to :post
end

Comment.create!(body: 'test')  # Fails: User must exist

class Order < ApplicationRecord
  belongs_to :coupon  # Should be optional since not all orders have coupons
end

Order.create!(total: 50)  # Fails: Coupon must exist

The Fix

Assign the current_user to the comment before saving. If an association is truly optional, add optional: true to the belongs_to declaration. Always ensure required foreign keys are set before persisting.

class Comment < ApplicationRecord
  belongs_to :user
  belongs_to :post
end

# Controller
def create
  @comment = Comment.new(comment_params)
  @comment.save!
end

class Comment < ApplicationRecord
  belongs_to :user
  belongs_to :post
end

# Controller
def create
  @comment = Comment.new(comment_params)
  @comment.user = current_user
  @comment.save!
end

Testing the Fix

require 'rails_helper'

RSpec.describe Comment, type: :model do
  describe 'validations' do
    it 'requires a user' do
      comment = build(:comment, user: nil)
      expect(comment).not_to be_valid
      expect(comment.errors[:user]).to include('must exist')
    end

    it 'is valid with a user and post' do
      comment = build(:comment)
      expect(comment).to be_valid
    end
  end
end

Run your tests:

bundle exec rspec spec/models/comment_spec.rb

Pushing Through CI/CD

git checkout -b fix/rails-belongs-to-required,git add app/controllers/comments_controller.rb,git commit -m "fix: assign current_user to comment before saving",git push origin fix/rails-belongs-to-required

Your CI config should look something like this:

name: CI
on:
  pull_request:
    branches: [main]
jobs:
  test:
    runs-on: ubuntu-latest
    services:
      postgres:
        image: postgres:16
        env:
          POSTGRES_PASSWORD: postgres
        ports: ['5432:5432']
    steps:
      - uses: actions/checkout@v4
      - uses: ruby/setup-ruby@v1
        with:
          ruby-version: '3.3'
          bundler-cache: true
      - run: bin/rails db:setup
      - run: bundle exec rspec

The Full Manual Process: 18 Steps

Here's every step you just went through to fix this one bug:

1. Notice the error alert or see it in your monitoring tool
2. Open the error dashboard and read the stack trace
3. Identify the file and line number from the stack trace
4. Open your IDE and navigate to the file
5. Read the surrounding code to understand context
6. Reproduce the error locally
7. Identify the root cause
8. Write the fix
9. Run the test suite locally
10. Fix any failing tests
11. Write new tests covering the edge case
12. Run the full test suite again
13. Create a new git branch
14. Commit and push your changes
15. Open a pull request
16. Wait for code review
17. Merge and deploy to production
18. Monitor production to confirm the error is resolved

Total time: 30-60 minutes. For one bug.

gem install bugstack

require 'bugstack'

Bugstack.init(api_key: ENV['BUGSTACK_API_KEY'])

Deploying the Fix (Manual Path)

1. Ensure all required associations are assigned before saving.
2. Mark truly optional associations with optional: true.
3. Run model specs.
4. Open a pull request.
5. Merge and verify in staging.

Frequently Asked Questions