Fix ActiveRecord::RecordNotSaved: Failed to save the record: a]before_save callback returned false in Rails

This error occurs when a before_save, before_create, or before_validation callback explicitly returns false or calls throw(:abort), which halts the save chain. Review your model callbacks to find which one is stopping the save and fix the condition or use throw(:abort) only when you genuinely want to prevent persistence.

Reading the Stack Trace

Here's what each line means:

• activerecord (7.1.3) lib/active_record/persistence.rb:131:in `save!': save! raises RecordNotSaved when the save is halted by a callback.
• app/models/order.rb:14:in `set_defaults': The set_defaults callback at line 14 is the callback that halted the save chain.
• app/controllers/orders_controller.rb:10:in `create': The controller create action triggered the save that was blocked.

Common Causes

class Order < ApplicationRecord
  before_save :set_defaults

  private

  def set_defaults
    self.status ||= 'pending'
    self.priority = false  # This returns false, halting the save!
  end
end

class Order < ApplicationRecord
  before_save :validate_total

  private

  def validate_total
    throw(:abort) if total.nil?  # Fires even for draft orders
  end
end

class Order < ApplicationRecord
  before_save :normalize_email
  before_save :validate_email

  def validate_email
    throw(:abort) unless email.match?(/@/)
  end

  def normalize_email
    # Runs first but email might still be nil
  end
end

The Fix

Add an explicit nil return at the end of the callback so the false assignment to self.priority is not treated as the callback return value. In Rails 5+, only throw(:abort) halts callbacks, but returning false from a before callback still halts in some configurations.

class Order < ApplicationRecord
  before_save :set_defaults

  private

  def set_defaults
    self.status ||= 'pending'
    self.priority = false
  end
end

class Order < ApplicationRecord
  before_save :set_defaults

  private

  def set_defaults
    self.status ||= 'pending'
    self.priority = false
    nil  # Explicit nil return so false assignment does not halt save
  end
end

Testing the Fix

require 'rails_helper'

RSpec.describe Order, type: :model do
  describe 'callbacks' do
    it 'saves successfully with defaults' do
      order = Order.new(total: 100, email: 'test@example.com')
      expect(order.save).to be true
      expect(order.status).to eq('pending')
    end

    it 'sets priority to false without blocking save' do
      order = Order.create!(total: 50, email: 'test@example.com')
      expect(order.priority).to be false
    end
  end
end

Run your tests:

bundle exec rspec spec/models/order_spec.rb

Pushing Through CI/CD

git checkout -b fix/rails-callback-halt,git add app/models/order.rb spec/models/order_spec.rb,git commit -m "fix: prevent callback from halting save with false return",git push origin fix/rails-callback-halt

Your CI config should look something like this:

name: CI
on:
  pull_request:
    branches: [main]
jobs:
  test:
    runs-on: ubuntu-latest
    services:
      postgres:
        image: postgres:16
        env:
          POSTGRES_PASSWORD: postgres
        ports: ['5432:5432']
    steps:
      - uses: actions/checkout@v4
      - uses: ruby/setup-ruby@v1
        with:
          ruby-version: '3.3'
          bundler-cache: true
      - run: bin/rails db:setup
      - run: bundle exec rspec

The Full Manual Process: 18 Steps

Here's every step you just went through to fix this one bug:

1. Notice the error alert or see it in your monitoring tool
2. Open the error dashboard and read the stack trace
3. Identify the file and line number from the stack trace
4. Open your IDE and navigate to the file
5. Read the surrounding code to understand context
6. Reproduce the error locally
7. Identify the root cause
8. Write the fix
9. Run the test suite locally
10. Fix any failing tests
11. Write new tests covering the edge case
12. Run the full test suite again
13. Create a new git branch
14. Commit and push your changes
15. Open a pull request
16. Wait for code review
17. Merge and deploy to production
18. Monitor production to confirm the error is resolved

Total time: 30-60 minutes. For one bug.

gem install bugstack

require 'bugstack'

Bugstack.init(api_key: ENV['BUGSTACK_API_KEY'])

Deploying the Fix (Manual Path)

1. Fix the callback return value in the model.
2. Add model specs verifying save succeeds.
3. Run the full test suite.
4. Open a pull request.
5. Merge and verify in staging.

Frequently Asked Questions